LBGG-541: Create user page - Githubissues

leaderboardsgg / leaderboard-site

Frontend of Leaderboards.gg

https://leaderboards.gg/

GNU General Public License v3.0

55 stars 20 forks source link

LBGG-541: Create user page #543

Closed erunks closed 1 year ago

erunks commented 1 year ago

What

api: Reran the generate:api command against the latest backend.
composables: Created a new composable to fetch the UserDetail from the backend, provided an ID.
pages: Create /user/[id] route.

Link to Issue

Closes https://github.com/leaderboardsgg/leaderboard-site/issues/541

Acceptance

Steps for testing

Get the backend repo running*
Create a user
Navigate to /user/[id] where the id corresponds to the newly created user
[ ] Should see the username on the page

*Note that I had to enable the backend to allow CORS requests. You can find that modification on my forked copy here

Images

erunks commented 1 year ago

One thing that feels weird to me is the interaction here between the two tech stacks. Having to allow CORS requests on the backend seems like a hack. It feels like we should be able to request across different localhost ports just fine, but that wasn't the case. Maybe something worth looking into? Maybe worth drudging up the docker repo again?