search

leadhomesa / oxygen

React component library
https://leadhomesa.github.io/oxygen/
MIT License
6 stars 1 forks source link

Complete colour sets not available #70

Closed seagyn closed 4 years ago

seagyn commented 4 years ago

All of the colours found in the design system are not available yet. Furthermore, they need have sane names that are easier to remember than light and lighter storm.

Colours can be found here: https://www.figma.com/file/bUBZY5aVyXYdedy2wCtDxr/Oxygen-Core?node-id=1%3A6500

The idea would be to have all colours with 1-6:

Coral1
Coral2
Coral3
Coral4
Coral5

With 2 always being the default Coral. In other words Coral = Coral2 = '#FF6A70'.

fllprbt commented 4 years ago

I am working on it. Are the top names in the image you provided ok (coral, storm, overcast)?

Do you need also a default Coral (without number) mapping to Coral 2?

seagyn commented 4 years ago

@fllprbt yeah, the names are good and you can map the default to colour 2 as per your example.

There are already colours which you can remove/replace with the new system.

fllprbt commented 4 years ago

I 've completed it https://github.com/leadhomesa/oxygen/pull/72/files

What should we do with colors that are not in the styles like (disabled, grey, gallery ...)?

seagyn commented 4 years ago

Thanks again!