leadpixel / htask

CLI task utility
3 stars 0 forks source link

Pedantry fails #1

Closed custommonkey closed 6 years ago

custommonkey commented 6 years ago

Calling stack test --pedantic on a clean checkout fails with the following message

--  While building custom Setup.hs for package htask-bin-0.1.0.0 using:
      /Users/jmartin/.stack/setup-exe-cache/x86_64-osx/Cabal-simple_mPHDZzAJ_2.0.1.0_ghc-8.2.2 --builddir=.stack-work/dist/x86_64-osx/Cabal-2.0.1.0 build exe:htask --ghc-options " -ddump-hi -ddump-to-file -fdiagnostics-color=always"
    Process exited with code: ExitFailure 1
    Logs have been written to: /Users/jmartin/code/htask/.stack-work/logs/htask-bin-0.1.0.0.log

    Configuring htask-bin-0.1.0.0...
    Preprocessing executable 'htask' for htask-bin-0.1.0.0..
    Building executable 'htask' for htask-bin-0.1.0.0..
    [ 1 of 32] Compiling HTask.Actions    ( src/HTask/Actions.hs, .stack-work/dist/x86_64-osx/Cabal-2.0.1.0/build/htask/htask-tmp/HTask/Actions.o )
    [ 2 of 32] Compiling HTask.CLI.Add    ( src/HTask/CLI/Add.hs, .stack-work/dist/x86_64-osx/Cabal-2.0.1.0/build/htask/htask-tmp/HTask/CLI/Add.o )
    [ 3 of 32] Compiling HTask.CLI.Complete ( src/HTask/CLI/Complete.hs, .stack-work/dist/x86_64-osx/Cabal-2.0.1.0/build/htask/htask-tmp/HTask/CLI/Complete.o )
    [ 4 of 32] Compiling HTask.CLI.Done   ( src/HTask/CLI/Done.hs, .stack-work/dist/x86_64-osx/Cabal-2.0.1.0/build/htask/htask-tmp/HTask/CLI/Done.o )
    [ 5 of 32] Compiling HTask.CLI.Drop   ( src/HTask/CLI/Drop.hs, .stack-work/dist/x86_64-osx/Cabal-2.0.1.0/build/htask/htask-tmp/HTask/CLI/Drop.o )
    [ 6 of 32] Compiling HTask.CLI.List   ( src/HTask/CLI/List.hs, .stack-work/dist/x86_64-osx/Cabal-2.0.1.0/build/htask/htask-tmp/HTask/CLI/List.o )
    [ 7 of 32] Compiling HTask.CLI.Pick   ( src/HTask/CLI/Pick.hs, .stack-work/dist/x86_64-osx/Cabal-2.0.1.0/build/htask/htask-tmp/HTask/CLI/Pick.o )
    [ 8 of 32] Compiling HTask.CLI.Remove ( src/HTask/CLI/Remove.hs, .stack-work/dist/x86_64-osx/Cabal-2.0.1.0/build/htask/htask-tmp/HTask/CLI/Remove.o )
    [ 9 of 32] Compiling HTask.CLI.Start  ( src/HTask/CLI/Start.hs, .stack-work/dist/x86_64-osx/Cabal-2.0.1.0/build/htask/htask-tmp/HTask/CLI/Start.o )
    [10 of 32] Compiling HTask.CLI.Stop   ( src/HTask/CLI/Stop.hs, .stack-work/dist/x86_64-osx/Cabal-2.0.1.0/build/htask/htask-tmp/HTask/CLI/Stop.o )
    [11 of 32] Compiling HTask.CLI.Summary ( src/HTask/CLI/Summary.hs, .stack-work/dist/x86_64-osx/Cabal-2.0.1.0/build/htask/htask-tmp/HTask/CLI/Summary.o )
    [12 of 32] Compiling HTask.Config     ( src/HTask/Config.hs, .stack-work/dist/x86_64-osx/Cabal-2.0.1.0/build/htask/htask-tmp/HTask/Config.o )
    [13 of 32] Compiling HTask.CLI        ( src/HTask/CLI.hs, .stack-work/dist/x86_64-osx/Cabal-2.0.1.0/build/htask/htask-tmp/HTask/CLI.o )
    [14 of 32] Compiling HTask.Output.Document ( src/HTask/Output/Document.hs, .stack-work/dist/x86_64-osx/Cabal-2.0.1.0/build/htask/htask-tmp/HTask/Output/Document.o )
    [15 of 32] Compiling HTask.Output.Formatters ( src/HTask/Output/Formatters.hs, .stack-work/dist/x86_64-osx/Cabal-2.0.1.0/build/htask/htask-tmp/HTask/Output/Formatters.o )
    [16 of 32] Compiling HTask.Output.Renderers ( src/HTask/Output/Renderers.hs, .stack-work/dist/x86_64-osx/Cabal-2.0.1.0/build/htask/htask-tmp/HTask/Output/Renderers.o )
    [17 of 32] Compiling HTask.Output     ( src/HTask/Output.hs, .stack-work/dist/x86_64-osx/Cabal-2.0.1.0/build/htask/htask-tmp/HTask/Output.o )
    [18 of 32] Compiling HTask.TaskApplication ( src/HTask/TaskApplication.hs, .stack-work/dist/x86_64-osx/Cabal-2.0.1.0/build/htask/htask-tmp/HTask/TaskApplication.o )

    /Users/jmartin/code/htask/packages/htask-bin/src/HTask/TaskApplication.hs:22:1: warning: [-Worphans]
        Orphan instance:
          instance (Monad m, T.MonadTrans t, CanTime m) => CanTime (t m)
        To avoid this
            move the instance declaration to the module of the class or of the type, or
            wrap the type with a newtype and declare the instance on the new type.
       |
    22 | instance (Monad m, T.MonadTrans t, CanTime m) => CanTime (t m) where
       | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^...

    /Users/jmartin/code/htask/packages/htask-bin/src/HTask/TaskApplication.hs:25:1: warning: [-Worphans]
        Orphan instance:
          instance (Monad m, T.MonadTrans t, CanRandom m) => CanRandom (t m)
        To avoid this
            move the instance declaration to the module of the class or of the type, or
            wrap the type with a newtype and declare the instance on the new type.
       |
    25 | instance (Monad m, T.MonadTrans t, CanRandom m) => CanRandom (t m) where
       | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^...

    /Users/jmartin/code/htask/packages/htask-bin/src/HTask/TaskApplication.hs:28:1: warning: [-Worphans]
        Orphan instance:
          instance (Monad m, T.MonadTrans t, CanUuid m) => CanUuid (t m)
        To avoid this
            move the instance declaration to the module of the class or of the type, or
            wrap the type with a newtype and declare the instance on the new type.
       |
    28 | instance (Monad m, T.MonadTrans t, CanUuid m) => CanUuid (t m) where
       | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^...

    <no location info>: error:
    Failing due to -Werror.

after running stack test subsequent calls to stack test --pedantic are successful

palf commented 6 years ago

Thanks @custommonkey, resolved in commit https://github.com/leadpixel/htask/commit/f01cc78f252b43486be805fdd2051820f54a1365

custommonkey commented 6 years ago

Pedantry is now successful, hope you're enjoying the sunshine.