search

leadstoloyals / node-agcod

Node.js api for the Amazon Gift Codes On Demand Web Services
5 stars 7 forks source link

Continue the development and maintenance of this repo #3

Open BlackFenix2 opened 3 years ago

BlackFenix2 commented 3 years ago

I keep getting this error running the published package in my repo.

TypeError: BigNumber is not a constructor

is this project currently maintained? I would rather fix this repo with a PR then have to fork the entire repo for commercial use.

ekkis commented 2 years ago

it doesn't seem this project is maintained. I'm thinking of forking and publishing. thoughts?

BlackFenix2 commented 2 years ago

@ekkis fork it!

christiaanwesterbeek commented 2 years ago

I'm the creator and I've stopped maintaining it a long time ago. You guys are very welcome to improve by any means.

It would probably best if we can prevent the fork from being published to npm as some kind of alias to agcod. I always hate when trying to figure out which of very similarly named libraries is the one to take.

So how about I make you guys full contributors to this repo? I suppose you can then do as much with this repo as I can. Not sure though what we need to do in order for you to be able to publish to https://www.npmjs.com/package/agcod ...

Btw, how is https://www.npmjs.com/package/amazon-gc ?

BlackFenix2 commented 2 years ago

@christiaanwesterbeek sure, i can be a contributer. as far as publishing goes do you publish via github actions or run the publish command locally? we would just need to be collabrators on the NPM package and we can publish away?

christiaanwesterbeek commented 2 years ago

I always just ran the npm publish command locally.

@BlackFenix2 I just added you as a Write collaborator to this Github repo

BlackFenix2 commented 2 years ago

@christiaanwesterbeek can you also add @ekkis if they are interested/

christiaanwesterbeek commented 2 years ago

@ekkis Just say the word...

@BlackFenix2 I also invited you as a maintainer to https://www.npmjs.com/package/agcod

ekkis commented 2 years ago

So how about I make you guys full contributors to this repo?

that would be terrific. I agree we should keep it under the same name in NPM. I have a PR already. just needs to be approved

ekkis commented 2 years ago

Btw, how is https://www.npmjs.com/package/amazon-gc ?

haven't looked into it but having write access to this I won't even bother to look because I can make this project what it needs to be

ekkis commented 2 years ago

@BlackFenix2 I also invited you as a maintainer to https://www.npmjs.com/package/agcod

you can add me too. I currently maintain a number of packages on npmjs

christiaanwesterbeek commented 2 years ago

@ekkis I invited you too now. As a writer of this Github repo. And as a maintainer on npm.

ekkis commented 2 years ago

wonderful. this is why open source works so well. when an author has moved on but there are others that care about the work, development can continue. I've already converted the package to a promise-based solution (that continues to support the old callback paradigm) and have updated the list of countries supported by Amazon now, included proper currency support and made other improvements. thank you for letting me publish on NPM. that way I don't have to publish under another name