leadstoloyals / node-agcod

Node.js api for the Amazon Gift Codes On Demand Web Services
5 stars 7 forks source link

Which is the config directory? #5

Closed ekkis closed 2 years ago

ekkis commented 2 years ago

the README states:

Create a development.json, sandbox.json and production.json in the config directory that looks like example.json.

so I am to create a file in the "config" directory. which is the config directory? the one in node_modules/node-agcod (methinks not)? can we amend the README to be more clear?

christiaanwesterbeek commented 2 years ago

It's the config directory that already exists, directly in the root where example.json is in.

christiaanwesterbeek commented 2 years ago

On second thought, you're right, this is ambiguous. When node-agcod is installed as a dependency, its config dir is inside node_modules/node-agcod, but that's not where you need to add the json files. It's only where an example.json is kept.

You need to create a config dir in the root of your own repo and add the json files there.

ekkis commented 2 years ago

mich besser. thank you