search

leafac / kill-the-newsletter

Convert email newsletters into Atom feeds
https://kill-the-newsletter.com
MIT License
2.31k stars 113 forks source link

HTML Pages all 404 #39

Closed SenorFusion closed 3 years ago

SenorFusion commented 3 years ago

Starting today, all of the HTML pages of my Kill The Newsletter Feeds are 404ing.

I typically open several newsletters in browser because they don't style well in my RSS reader.

https://kill-the-newsletter.com/alternate/<page-key>.html

This is happening on all of my feeds, not just one

Thanks!

leafac commented 3 years ago

Hi @SenorFusion,

Thanks for reaching out with the issue report.

The links should be https://kill-the-newsletter.com/alternates/<page-key>.html, not https://kill-the-newsletter.com/alternate/<page-key>.html (note the s in alternates). Can you please try those and see if they work for you?

I double-checked just now and the links Atom feed are correct (they’re the <link rel="alternate" ... /> under each <entry>). From where did you get the wrong links?

SenorFusion commented 3 years ago

@leafac Yes, I see what you mean. This may turn out to be a problem with my RSS reader.

-Fedora 32 -Liferea 1.13.5

What I've found:

-You are correct, the raw XML is providing the alternate feed URL correctly -Somehow the headline (link to post) is getting converted to this format (I was incorrect in my OP): https://kill-the-newsletter.com/alternate/<feed-key>/<page-key>.html

When I manually change that link to https://kill-the-newsletter.com/alternates/<page-key>.html it works fine.

It seems to be constructing an incorrect URL for the headline link based on what is in the feed.

Example shown in the pictures.

EDIT: This just started happening in the last few days.

alternate-links alternate2

SenorFusion commented 3 years ago

Upon further review, it seems like maybe the feedreader is expecting a URL in the <id> field and, not finding one, tries to construct one based on the feed URL combined with the item key. (Which would probably work with a normal domain / URL scheme)

<id>urn:kill-the-newsletter:_<page-key>_</id>

leafac commented 3 years ago

No, the problem is that I deployed a new version of Kill the Newsletter! two days ago in which I changed the URLs. Your feed reader is going off of a stale cache. It won’t be an issue for new entries coming up…

Mystery solved; I’m closing the issue for now. Let me know if it’s a problem with new entries.

And thanks for using Kill the Newsletter! 🙌