search

leafac / kill-the-newsletter

Convert email newsletters into Atom feeds
https://kill-the-newsletter.com
MIT License
2.31k stars 113 forks source link

Fetch favicon from newsletter? #92

Closed I7T5 closed 3 weeks ago

I7T5 commented 1 year ago

Is it possible to fetch favicon from the newsletter and use it instead of kill the newsletter's own favicon? I use kill the newsletter for NetNewsWire. Would be nice to have this feature.

leafac commented 3 weeks ago

Hi @I7T5,

I love the idea, but there’s a complication: We don’t know which website is sending the newsletter. We could either ask the user to provide us with that information when creating the feed, or we could try to deduce that from the From fields on the emails that we receive.

In either case, I believe that the cost/benefit for creating and maintaining this feature isn’t there yet.

But I’ll keep that in mind and if more people keep asking for this then I may get around to it.

Best.

kutsan commented 3 weeks ago

If it helps, I'm also eager for this feature to be implemented.

I think favicon should be retrieved from From fields for simplicity.

leafac commented 3 weeks ago

Hmmm, alright, let’s give it a try. I implemented this as part of 2.0.6. It sets the <icon> based on the from of the email.

Asmatzaile commented 2 weeks ago

Thanks for the feature! It doesn't always work for me; not all websites have the icon in root/favicon.ico. Also, if the mailing list doesn't accept kill the newsletter and a user tries to resend the message through their mail, this implementation won't work either. Could you add a field in the 'feed created' page (where you can copy subscription and feed addresses) to optionally add a link to an image that can work as an icon? That way, if the link is manually added, the feed could have the specified icon, and else, it could try to set it based on the from of the email, as it does now.

leafac commented 2 weeks ago

@Asmatzaile: Thanks for the feedback.

I’ll look into that at some point…

leafac commented 1 week ago

I added an option for you to set a custom icon. You may access it from a link at the bottom of the feed entries, as well as when you create the feed.