search

leaffm / react-infinite-carousel

React simple infinite carousel with lazy loading and responsive support
MIT License
116 stars 19 forks source link

When I use the paging and then resize, the carousel goes crazy. #1

Closed pfadiaz closed 7 years ago

pfadiaz commented 7 years ago

STEPS:

  1. Open the URL: https://react-infinite-carousel-vrtbcxaige.now.sh/
  2. Resize the screen by dragging each corner

RESULT

When resizing the screen, the carousel is not keeping the same elements positions, it start moving by its own.

Please see the following video for more details:

https://screencast.com/t/Uxygs0HTN

samiq commented 7 years ago

this bug happens when you have selected a page, after that the resizing goes crazy

samiq commented 7 years ago

thinking about how this works, I think maybe we should just use the first items of the page where we are in as anchor (just like it happens when you haven't navigated to another page) while resizing.

gl0gl0 commented 7 years ago

Fixed on develop e465d3d @pfadiaz Test url: https://react-infinite-carousel-uszkpdnpia.now.sh/

samiq commented 7 years ago

super bien @gl0gl0 👍

pfadiaz commented 7 years ago

@gl0gl0 there is just a small detail in safari, FF and IE. When you select page 1 or page 2 and then play with the size of the browser (by dragging the corners.) the first element from the carousel and the second are blinking and switching color. can you please take a look at this specific scenario. Chrome is awesome, is very smooth. Thanks!

gl0gl0 commented 7 years ago

Fixed blinking issue with commit for issue #6 Test url: https://react-infinite-carousel-snviaxlzma.now.sh/

pfadiaz commented 7 years ago

Verified pending scenario. Marking bug as closed.