search

leaffm / react-infinite-carousel

React simple infinite carousel with lazy loading and responsive support
MIT License
116 stars 19 forks source link

[Mobile- Tablet] Landscape view adjust element arrangement #7

Closed pfadiaz closed 7 years ago

pfadiaz commented 7 years ago

STEPS:

Having 20 elements in total in the carousel in portrait view, Tap the page # 7 to display the last elements of the carousel. Now flip the device to turn the landscape view on.

RESULT:

See that now the pagination has 5 pages which is perfect because is splitting the 20 items in groups of 4, however the carousel is placing the first element as part of the last set of 4 items.

If you click the Page # 1 you can see that the elements are now properly arranged

gl0gl0 commented 7 years ago

Hi JP,

I fixed the blinking slide at the end of the carousel, it was being loaded every single time. you can now test in this link: https://react-infinite-carousel-amrwphqwci.now.sh/

About the issue of being in portrait mode, last carousel page and then changing to landscape view: It shows the first slide because the default behavior on responsive is to show/hide the slides on the right, leaving the left fixed. It might be weird for the user to change the position to avoid showing the first slide. Netflix seems to work the like that as well.

pfadiaz commented 7 years ago

Thanks for the update @gl0gl0 . Marking this bug as verified