search

leaflabs / maple-bootloader

Bootloader firmware for the Maple ARM Cortex-M3 development board from LeafLabs
http://leaflabs.com
135 stars 117 forks source link

Fixing dfu.c to allow compiling with -Os #9

Closed Gregwar closed 10 years ago

Gregwar commented 10 years ago

This fixes warnings and volatile variables, making the booloader working with -Os Before this change, the bootloader was not able to upload any data with optimization enabled

This takes the bootloader size from ~16k to ~7k

Gregwar commented 10 years ago

BTW, is it safe to change USER_CODE_FLASH, to lower value? My build of the bootloader is about 7k, I could set it to 0x8002000 for instance Why is it 0x8005000 now, 20K is really big compared with the bootloader size, it isn't?

mbolivar commented 10 years ago

Your'e right, it's too large, but we're stuck with that as a default value since boards we've already sold have bootloaders that jump there.

It's OK to change it, but you need to make similar changes to VECT_TAB_FLASH in the libmaple build system.

On 04/23/2014 05:00 AM, Grégoire Passault wrote:

BTW, is it safe to change |USER_CODE_FLASH|, to lower value? My build of the bootloader is about 7k, I could set it to |0x8002000| for instance Why is it |0x8005000| now, 20K is really big compared with the bootloader size, it isn't?

— Reply to this email directly or view it on GitHub https://github.com/leaflabs/maple-bootloader/pull/9#issuecomment-41139015.

mbolivar commented 10 years ago

Looks good to me. Thanks for submitting this!