search

leaflet-extras / leaflet-providers

An extension to Leaflet that contains configurations for various free tile providers.
https://leaflet-extras.github.io/leaflet-providers/preview/
BSD 2-Clause "Simplified" License
2.15k stars 668 forks source link

Introduce HEREv3 (using apiKey instead of app_id and app_code) #343

Closed mcguffin closed 4 years ago

mcguffin commented 4 years ago

Use Tile API-URL and apiKey as described in latest HERE docs: https://developer.here.com/documentation/map-tile/dev_guide/topics/quick-start-map-tile.html Will fix #342

brunob commented 4 years ago

@jieter any thoughts ?

jieter commented 4 years ago

Yes, the readme links to the preview, using [Available HEREv3 layers](http://leaflet-extras.github.io/leaflet-providers/preview/#filter=HEREv3), but 'HERE' is completely ignored from preview: https://github.com/leaflet-extras/leaflet-providers/blob/52bfb509ab608ff0ad524d6812384883df9f03ed/preview/preview.js#L81

The reason being that we kept exceeding the free plan, even with a single layer in the preview list.

I'd say there is limited value in adding these providers we cannot reliably show previews for, as they are not really discoverable.

brunob commented 4 years ago

@jieter nice catch maybe it could be better if @mcguffin remove the mention & link to preview for HERE in the readme ?

brunob commented 4 years ago

LGTM

jieter commented 4 years ago

Merged, thanks @mcguffin

stell commented 4 years ago

Can someone tag 1.9.2 with this update? Thanks!

brunob commented 4 years ago

@stell no hurry, we were waiting to merge others PR, now that it's done, we will shortly publish a new tag when our free time will allow it :)