search

leaflet-extras / leaflet-providers

An extension to Leaflet that contains configurations for various free tile providers.
https://leaflet-extras.github.io/leaflet-providers/preview/
BSD 2-Clause "Simplified" License
2.15k stars 669 forks source link

added Stadia Maps to list of providers #344

Closed holtalanm closed 4 years ago

holtalanm commented 4 years ago

https://stadiamaps.com/

ToS: https://docs.stadiamaps.com/#legal-stuff

Implementation from their documentation regarding Leaflet: https://docs.stadiamaps.com/raster/#displaying-a-map-leaflet

brunob commented 4 years ago

@jieter any thoughts ?

jieter commented 4 years ago

LGTM

brunob commented 4 years ago

Thx @holtalanm :)

jieter commented 4 years ago

Hmm, there is no preview API key configured, so http://leaflet-extras.github.io/leaflet-providers/preview/#filter=Stadia shows grey maps.

We should either keep it out of the preview, or add an example API code: https://github.com/leaflet-extras/leaflet-providers/blob/86278408c9896e6883ffa0d6217ea3b5d63d8b92/preview/shared.js#L4-L12

brunob commented 4 years ago

As what i can read in their doc you don't need an API key to use the tiles, but the error is 403 Forbidden Request forbidden by administrative rules., and i've seen this one while testing their static map API ref https://seenthis.net/messages/822843#message822884

So, there might be a temporary bug from their side ?

holtalanm commented 4 years ago

while their api has a free tier, users still need to have an account, and have their domain whitelisted within that account. This is explained in their leaflet documentation, as well:

everything should work seamlessly as long as you have an active plan for your domain

Not sure where that should be communicated within the leaflet-providers codebase, though.

brunob commented 4 years ago

@holtalanm so you should add this mention in the readme, and we should from our part don't list these tiles in the demo page.

lseelenbinder commented 4 years ago

Hi @holtalanm, @brunob, we (I'm co-founder of @stadiamaps) just added a property on our side allowing the preview domain (leaflet-extras.github.io). Are there any other domains we should add so there's not a weird grey space where our maps should be? 😄

jieter commented 4 years ago

@lseelenbinder leaflet-extras.github.io should be enough, thanks!