Removing trailing comma of death

leaflet-extras / leaflet-providers

An extension to Leaflet that contains configurations for various free tile providers.

https://leaflet-extras.github.io/leaflet-providers/preview/

BSD 2-Clause "Simplified" License

2.15k stars 669 forks source link

Removing trailing comma of death #346

Closed jimsalabim closed 4 years ago

jimsalabim commented 4 years ago

Some linters can be quite strict.

brunob commented 4 years ago

Thx for the PR, but our eslint config doesn't match these ones. In think we can merge the PR, but we should also update eslint conf for that. Any thoughts @jieter ?

jieter commented 4 years ago

In my opinion, these trailing comma's have the benefit of more stable diffs. So I'm -1 on merging this.

brunob commented 4 years ago

Nice catch for the diffs, closing this one :)