leaflet-extras / leaflet-providers

An extension to Leaflet that contains configurations for various free tile providers.
https://leaflet-extras.github.io/leaflet-providers/preview/
BSD 2-Clause "Simplified" License
2.14k stars 666 forks source link

Change release tool #406

Closed brunob closed 1 year ago

brunob commented 2 years ago

mversion seems a bit unmaintained : latest commit from 2020 & many dependabot PR waiting since a while https://github.com/mikaelbr/mversion/pulls

Even if mversion still work for now, the dependabot message "We found potential security vulnerabilities in your dependencies." point to an alert linked to mversion.

I've started to search for an alternative tool, and found these one :

Bonus, all these tools could also fix #320 !

Any thoughts @jieter ?

jieter commented 2 years ago

Yes, we should probably bring this process up to date. Ideally, I'd like to be able to release from within GitHub. I never looked into this before, but a quick google search surfaced this action:

https://github.com/marketplace/actions/npm-bump

From it's description, it turns out the npm tool already supports incrementing the version: https://docs.npmjs.com/cli/v7/commands/npm-version#description. This might be enough to replace mversion.

brunob commented 2 years ago

Yes, we should probably bring this process up to date. Ideally, I'd like to be able to release from within GitHub. I never looked into this before, but a quick google search surfaced this action:

https://github.com/marketplace/actions/npm-bump

Nice, that's the one i've found the most suitable for our needs :)

From it's description, it turns out the npm tool already supports incrementing the version: https://docs.npmjs.com/cli/v7/commands/npm-version#description. This might be enough to replace mversion.

I've seen that too.

Anyway, nice things to come :)