RfC: migrate to Typescript, enable tree shaking

leaflet-extras / leaflet-providers

An extension to Leaflet that contains configurations for various free tile providers.

https://leaflet-extras.github.io/leaflet-providers/preview/

BSD 2-Clause "Simplified" License

2.14k stars 666 forks source link

RfC: migrate to Typescript, enable tree shaking #412

Open simon04 opened 2 years ago

simon04 commented 2 years ago

When only requiring one or two layers, leaflet-providers is overkill since it weights 22.9 kB

To improve on that I'd like to suggest/discuss:

export provider definitions such as OpenStreetMap or Esri as separate modules
pass one of those provider definitions in the layer constructor
migrate to TypeScript
use esbuild for bundling

I'm happy to hear your thoughts!

brunob commented 2 years ago

Thx for the PR, i'm totally out of TypeScript things, let's wait for @jieter thought on this...

brunob commented 2 years ago

bump @jieter personally this change would push me out of the project.

vincerubinetti commented 11 months ago

It would help if there was a least a declaration file in the repo. There seems to be a @types/leaflet-providers definition, though I can't get TS to recognize it.