leafo / gh-actions-lua

GitHub action for Lua/LuaJIT
85 stars 27 forks source link

Update Node to version 20 #45

Open Rathoz opened 8 months ago

Rathoz commented 8 months ago

Github Action is transitioning away from Node 16 as it's End of Life.

https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

britzl commented 7 months ago

@alerque may I ask when this will be merged?

alerque commented 7 months ago

@britzl I'm all for it but this is @leafo's project and I haven't been grated any special collaborator permissions so my approval doesn't count for much except to say I've had a look at it and think it's a good thing.

britzl commented 7 months ago

@britzl I'm all for it but this is @leafo's project and I haven't been grated any special collaborator permissions so my approval doesn't count for much except to say I've had a look at it and think it's a good thing.

Ah, I see. I thought you were one of the maintainers. Have you tested it on a fork to verify that it is indeed working or only looked through the changes?

alerque commented 7 months ago

I believe I did, but it's been a minute. It's pretty easy to do your self if you want to verify this as an extra data point for @leafo (and/or just make use of it until it merges). You just have to change the name of the step in your own workflow to the fork behind this PR and use the patch-1 branch for the version.

BreakBB commented 6 months ago

This will fix #42