search

leafo / lessphp

LESS compiler written in PHP
http://leafo.net/lessphp
Other
2.2k stars 529 forks source link

is_file Warnings #595

Closed piccaso closed 5 years ago

piccaso commented 9 years ago

I've came across situations where findImport was walking out of open_basedir (i.e.: Joomla! 3.4) and i thought it would be the best idea to disable only that Warning instead of disabling all Warnings.

Please consider adding this change (or something similar) to your project, so i don't have to apply that patch to every after every update :)

Thanks!

Krinkle commented 5 years ago

Thanks. It seems the code is already checking readability and existence before attempting to read or open a file. This means that in general there cannot be warnings.

The issue you describe is not about files not existing, but about files being referenced outside the designated security zone (e.g. open_basedir).

This is an error, and there should be a warning about that. It means you have a stylesheet that is likely not working correctly and needs to be addressed.

Either the open_basedir needs to be changed with permission from the server administrator, or the stylesheet modified to not try to import from outside the zone.