leafo / lessphp

LESS compiler written in PHP
http://leafo.net/lessphp
Other
2.2k stars 527 forks source link

Parse error with CSS Grid Layout and named grid lines/areas #637

Open Celti opened 6 years ago

Celti commented 6 years ago

When attempting to use named grid lines and areas in a LESS stylesheet I get a parse error from lessphp. less.js works just fine.

Fatal Error: parse error: failed at `grid-template-rows:` ../../lib/tpl/dokuwiki-template-grid/css/structure.less on line 12
#dokuwiki__site {
    display: grid;
    box-sizing: border-box;
    width: 100vw;
    height: 100vh;
    grid-template-rows:
        [header] 2em
        [content] 1fr
        [footer] 2em;
    grid-template-columns:
        [left] minmax(auto, min-content)
        [center] auto
        [right] minmax(auto, min-content);
    grid-gap: 1px;
}
Michaelsy commented 6 years ago

A trick to insert (nearly) every unparsed code in LESSPHP: https://github.com/splitbrain/dokuwiki/issues/2254#issuecomment-386814503

blizzardengle commented 6 years ago

I made a patch that is working. This protects CSS grid names automatically for you and should allow for variables to be used in the statement if needed; I have not tested if variables work.

It's not elegant but it works: Pull Request #643

Rainbow-Spike commented 5 years ago

~"screen CSS code from LESS parser"