search

leafo / pgmoon

A pure Lua Postgres driver for use in OpenResty & more
MIT License
390 stars 93 forks source link

add Dockerfile and docker-compose for local testing #100

Closed jprjr closed 3 years ago

jprjr commented 3 years ago

Split out from #97

Adds a Dockerfile and docker-compose for quickly testing locally against different versions of Lua.

I tried to make it as close to the Travis setup as reasonably possible, it also uses parts of the .travis.yml file during the build.

leafo commented 3 years ago

edit: I put the comment that was here on the wrong issue, ignore if you got email notification

leafo commented 3 years ago

Maybe something that can be put in the wiki? I'm not sure I want this project to take ownership for some docker files, since at the end of the day I would not be maintaining it. I do recognize it's useful but it's not the workflow I use.

leafo commented 3 years ago

So I spent a bunch of time putting together github actions and contemplating using a variant of this, but I decided to try to utilize the matrix support in github actions so we could have parallel builds for different versions of postgres & lua.

The solution I pushed now uses the official postgres docker image to spin up a postgres instance, which should hopefully make the tests more portable for those wanting to run them in development.

The .travis build files have been completely removed though, so I'm going close this PR. Thanks for submitting it.