search

leafo / pgmoon

A pure Lua Postgres driver for use in OpenResty & more
MIT License
394 stars 93 forks source link

Support HAProxy socket type from init configuration #115

Closed mecampbellsoup closed 2 years ago

mecampbellsoup commented 2 years ago

Related to https://github.com/leafo/pgmoon/issues/114.

mecampbellsoup commented 2 years ago

@leafo I guess I should've made the changes to the moon files instead of the .lua files and then run make build to generate the Lua file changes?

mecampbellsoup commented 2 years ago

Hi @leafo, do you know when we might expect your review? Thank you.

leafo commented 2 years ago

The only unanswered issue is about the core global. Is that really the only way to access haproxy, a global variable named core?

mecampbellsoup commented 2 years ago

The only unanswered issue is about the core global. Is that really the only way to access haproxy, a global variable named core?

https://www.arpalert.org/src/haproxy-lua-api/1.6/index.html#core-class

mecampbellsoup commented 2 years ago

Hi @leafo we are still maintaining our fork and it's a bit cumbersome, did I answer your question about the core class?

mecampbellsoup commented 2 years ago

Hi @leafo we are still maintaining our fork and it's a bit cumbersome, did I answer your question about the core class?

@leafo ping, please let us know your thoughts on this PR 🙏

mecampbellsoup commented 2 years ago

Closing in favor of https://github.com/leafo/pgmoon/pull/125.