search

leafo / scssphp

SCSS compiler written in PHP
MIT License
1.34k stars 216 forks source link

Proposal (and bug): Update minimum PHP version to 5.6 #679

Closed timelsass closed 5 years ago

timelsass commented 5 years ago

Recent changes introduced a couple of areas that use class name resolution via $className::class. This feature was added in 5.5, so 5.4 installs are impacted.

found in: https://github.com/leafo/scssphp/blob/master/src/Compiler.php#L1493 https://github.com/leafo/scssphp/blob/master/src/Compiler.php#L2141

I'd suggest bumping to a minimum of 5.6 to start the process of making php 7 the minimum eventually

robocoder commented 5 years ago

That was an unintentional compat buster. =P

robocoder commented 5 years ago

Fixed in v0.8.2

timelsass commented 5 years ago

thanks ! :)

mahagr commented 5 years ago

@robocoder Which release is the last one to work with PHP 5.4?

mahagr commented 5 years ago

Answering to my own question: last version working with PHP 5.4 is scssphp 0.8.0

robocoder commented 5 years ago

If you run composer with --ignore-platform-reqs, I believe 1.0 will still work with PHP 5.4.

mahagr commented 5 years ago

It will not because of ::class call which is PHP 5.5 only feature.

mahagr commented 5 years ago

Here are the correct links: https://github.com/leafo/scssphp/blob/v0.8.1/src/Compiler.php#L1493 https://github.com/leafo/scssphp/blob/v0.8.1/src/Compiler.php#L2141