Interpolation in comments

leafo / scssphp

SCSS compiler written in PHP

MIT License

1.34k stars 216 forks source link

Interpolation in comments #702

Closed Cerdic closed 5 years ago

Cerdic commented 5 years ago

Fix #565

Cerdic commented 5 years ago

It suddenly hits me in the shower that there was an infinite loop with a single #{ sequence in the comments, so fixing it with additional test case - and also saw there was a forgotten var_dump in the PR, which is really bad :p

Cerdic commented 5 years ago

And added a fix for #479 in the same PR as its still on comment topic and would have had some merge conflict in a separate PR. I'm done with this PR for real now :)