fix Trying to access array offset on value of type null

leafo / scssphp

SCSS compiler written in PHP

MIT License

1.34k stars 214 forks source link

fix Trying to access array offset on value of type null #710

Open remicollet opened 5 years ago

remicollet commented 5 years ago

PHP 7.4 compatibility

remicollet commented 5 years ago

I'm aware this project is abandoned. This is for legacy app (GLPI 9.4) while newer version (9.5) will use scssphp/scssphp

LukeTowers commented 4 years ago

Looks like it's semi applicable to https://github.com/scssphp/scssphp/commit/66675c1553b7e9d7c480d8aaedbf7c72374647cf @robocoder, not sure if the other two changes are needed too

mahagr commented 4 years ago

FYI:

If someone really needs the old leafo/scssphp because of reasons, here is how you can do it:

PHP 7.4 fix: https://github.com/gantry/gantry5/blob/develop/src/platforms/grav/classes/Leafo/ScssPhp/Compiler.php

You can then autoload the modified file from you composer: https://github.com/gantry/gantry5/blob/develop/src/platforms/grav/composer.json#L23

mediaclinic commented 3 years ago

This PHP7.4 fix really helped to fix the problem with SCSS. Thanks @mahagr. Is this fix going to be part of the official package, @LukeTowers? Any change to merge this fix @leafo?

mahagr commented 3 years ago

The project has been abandoned because of the person who owns this repository hasn't been around for long time. So I see no hopes for fixing this issue. Just raise the minimum php requirement to 5.6 and use scssphp/scssphp instead.