search

leafo / sightreading.training

🎹 Sight reading training tool
http://sightreading.training
438 stars 76 forks source link

The octave indication on the keyboard is not correct. #108

Open sergioprogrammatore opened 2 years ago

sergioprogrammatore commented 2 years ago

I think the octave indication on the keyboard is not correct. I think they are all moved forward by one unit: when it is written C5 in reality, for me, it should be written C4, and similarly all the others.

sloisel commented 2 years ago

I second this, but it's not just the octave indications. When playing with a MIDI connected keyboard, it's all off by 1 octave compared to what is on the sheet music. When the sheet music says "middle C", it's off by 1 octave.

This is very unfortunate, I'm using this with my 7 year old kid and he already sometimes plays things in the wrong octave, I'm worried this will reinforce his bad habit.

rookie86 commented 2 years ago

Yeah, onscreen piano is off by an octave.

My 88 keys midi keyboard is working correctly though. Perhaps there is a problem with keyboards with less keys?

leafo commented 1 year ago

@sloisel

I second this, but it's not just the octave indications. When playing with a MIDI connected keyboard, it's all off by 1 octave compared to what is on the sheet music. When the sheet music says "middle C", it's off by 1 octave.

Although the note labels used on the onscreen keyboard (and a few other places) start at C1 instead of C0, the actual MIDI message parsing treats MIDI Note Number 60 as Middle C, which is the universal standard. If your keyboard is an octave off then you likely have enabled the octave transpose feature on your keyboard.

pgm-bot commented 10 months ago

Will the label get fixed to start at C0 so the middle C is C4?