Port to 1.20.x - Githubissues

leafreynolds / cosmere

Bringing The Cosmere to Minecraft!

MIT License

26 stars 21 forks source link

Port to 1.20.x #102

Open leafreynolds opened 7 months ago

leafreynolds commented 7 months ago

Remaining work

[x] Data generation code
[x] Fix curio slots
[x] metal vial custom recipe
[x] tools itemgroup -> creative tabs
[ ] good settings for ore generation
[x] Feruchromium not increasing fortune
[x] Cosmere copper ingots should be replaced with vanilla variant
[ ] Refactor all uses of SomeEnum.values() to one class, so as to not assign new memory when called. It should do it once on construction in a unified enumsutils class or something
[ ] fix vanilla night vision?
[ ] Advancements?
[ ] moon to do QA pass on sandmastery

DiceOf20 commented 6 months ago

Best of luck Leaf!!

R0b0r0b commented 6 months ago

Good luck Leaf, you can do it!! Strength before Weakness!

Gerbagel commented 1 day ago

Fixed f-chromium in 9480f55a1aa4b81ae41a365598899da1a8e5b33d

R0b0r0b commented 1 day ago

Nice one, Gerbagel! Though Leaf, I'm not sure that you should replace Cosmere copper ingots with vanilla ones - I've found that vanilla copper, once it's become exposed or weathered, no longer qualifies as Pushable/Pullable. (Or just make the weathered/exposed variants also Pushable/Pullable, now I think about it!)

Gerbagel commented 1 day ago

Nice one, Gerbagel! Though Leaf, I'm not sure that you should replace Cosmere copper ingots with vanilla ones - I've found that vanilla copper, once it's become exposed or weathered, no longer qualifies as Pushable/Pullable. (Or just make the weathered/exposed variants also Pushable/Pullable, now I think about it!)

This we fix :) Should just be a datapack change to add those specifically as pushable