search

leafreynolds / cosmere

Bringing The Cosmere to Minecraft!
MIT License
25 stars 19 forks source link

Hemalurgy and Feruchemy rendering redesign. #30

Closed X66Herobrine66X closed 10 months ago

X66Herobrine66X commented 10 months ago

Changes proposed in this pull request:

Added 6 more bind points around the players rib cage to match canonical bind points.

X66Herobrine66X commented 10 months ago

image

Looks great :)

While you are in the area, can you move the linchpin spike from being bound to the head, and instead is at the top of the torso above the back spike?

I can try. It's getting pretty late tonight where I am, and I've been working for several hours on smoothing out the spikes so they don't jut out as much. I also added a third arm spike/bracelet slot, smoothing them out as well as the hand spike, plus a 2nd back slot as shown here. What do you think? image I'll try and work on the linch pin tomorrow.

leafreynolds commented 10 months ago

no rush at all, next curseforge update wont be for another week or two at the minimum, but also may be longer

X66Herobrine66X commented 10 months ago

no rush at all, next curseforge update wont be for another week or two at the minimum, but also may be longer

Will this work, or do you want it slightly lower? As it is right now, the head obstructs the view of it when you tilt your head back. image image

leafreynolds commented 10 months ago

Will this work, or do you want it slightly lower? As it is right now, the head obstructs the view of it when you tilt your head back.

Let's put it a little lower so it's less covered when the head is tilted back, but otherwise looks good :)

X66Herobrine66X commented 10 months ago

Will this work, or do you want it slightly lower? As it is right now, the head obstructs the view of it when you tilt your head back.

Let's put it a little lower so it's less covered when the head is tilted back, but otherwise looks good :)

How about this? I also added a secondary cube to the back of the eye spikes and shrunk them down. Front is the same size, but flatter against the face like the rib spikes. It's hard to tell in third person though. image

leafreynolds commented 10 months ago

How about this? I also added a secondary cube to the back of the eye spikes and shrunk them down. Front is the same size, but flatter against the face like the rib spikes. It's hard to tell in third person though.

I'd prefer to keep the eye spikes the same size, as 2x2 pixels will cover eyes in most player skins (like mine), other wise it looks real weird.

Otherwise, looking good. Did you add an extra back spike to match the hemalurgy poster?

leafreynolds commented 10 months ago

disregard last comment, clarification was provided in discord

X66Herobrine66X commented 10 months ago

I've got an update for you on my progress. I've extended the back spikes by 2 more to better match this image. I've split certain sections into the following categories so we can whitelist only certain spike types: