leafreynolds / cosmere

Bringing The Cosmere to Minecraft!
MIT License
26 stars 21 forks source link

[Aviar] Grey Aviar does not consistently provide benefit (Highlight targeting enemies) #69

Open MelficeSilesius opened 11 months ago

MelficeSilesius commented 11 months ago

Issue description

The grey parrot-turned-Aviar (tamed, of course) does not provide its benefit - the highlighting of enemies targeting the player - in a consistent manner. In the dozen-or-so (neutral and aggressive) mobs that I've tested this on, only once did the effect trigger on a neutral (non-vanilla) mob that I attacked. Skeletons, zombies, and creepers do not receive the highlight. The parrot is within range of the player

This issue occurs on my current modpack (no vanilla mob behaviour-altering mods installed), and in a completely clean pack that only has Cosmere and Aviar (plus Curios, and JEI for dependencies and spawning purposes) installed.

The only thing I've not tried - though I have no idea how it would be relevant as the mob ought to be the same - is to test this with a naturally spawned parrot as opposed to a spawn egg parrot.

EDIT: This issue is specific to the Grey Aviar, though it may benefit to check all the variants. The Grey Aviar is just the most obvious one where it doesn't work, considering the highlight.

Steps to reproduce

1) Spawn a parrot in 2) Tame parrot with seeds and feed Fruit of Patji 3) Let neutral and hostile mobs spawn, then let them target you 4) Expect a highlight around those mobs, but it does not consistently appear, per the issue

Minecraft version

1.19.2 (Latest)

Forge version

43.3.5

Cosmere version

CosmereAviar-1.19.2-43.1.3-0.5.80.jar

Other relevant versions

No response

If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)

No response

leafreynolds commented 11 months ago

So it turns out that the targeting doesn't get synced to clients 🙃 which explains why it was working briefly, until I fixed the other bug that was making Aviar crash servers.

I'll have to figure out an alternative, since this stuff needs to be client side only.