leafreynolds / cosmere

Bringing The Cosmere to Minecraft!
MIT License
25 stars 21 forks source link

[Allomancy] Iron/Steel force improvement #87

Open leafreynolds opened 9 months ago

leafreynolds commented 9 months ago

Strength in iron/steel should also increase the force that pushing and pulling exerts when used. Currently strength in the metals only increases range.

See AllomancyIronSteel.moveEntityTowards for where this change would need to be made. https://github.com/leafreynolds/cosmere/blob/290fd8cd1594a952a8a0cd737e1ef612b6f7d50c/src/allomancy/java/leaf/cosmere/allomancy/common/manifestation/AllomancyIronSteel.java#L363

As usual, testing will be needed, so force value should be config compatible.

genzarchitect commented 8 months ago

I would love to work on this. Can you assign it to me

leafreynolds commented 8 months ago

I would love to work on this. Can you assign it to me

Happy to give you a try at it :) have fun~

genzarchitect commented 8 months ago

@leafreynolds What will be the strength factor of different metal type iron/steel . Because we need to get the Strength of that ? is there any method ?

leafreynolds commented 8 months ago

@leafreynolds What will be the strength factor of different metal type iron/steel . Because we need to get the Strength of that ? is there any method ?

Different metals don't matter for the purpose of pushing? Excluding aluminum, which can't be seen allomantically anyway.

I would just add the strength factor as a config value, which can then be played with until we find the right default value.

SoaringEaqle commented 2 weeks ago

@genzarchitect Are you still working on this? If not could I take this one on?