league-of-legends-devs / LoL-item-sets

[discontinued] A Windows application that downloads and installs the League of Legends item sets from the website 'https://lol-item-sets-generator.org'. Mac version : https://github.com/league-of-legends-devs/LoL-item-sets-Mac
MIT License
32 stars 6 forks source link

Some Champions are Missing #14

Closed Dakoats closed 6 years ago

Dakoats commented 6 years ago

I'm not entirely sure if this is an issue with connecting to the API or not, but about a dozen or so champions are missing when generating item sets. Example here https://imgur.com/OBp3X6F Going to https://lol-item-sets-generator.org/sets shows that, as of right now, these champions are also missing from the list. https://imgur.com/UcJrEkf

Ilshidur commented 6 years ago

Thank you for your report.

The item sets are generated from the champion.gg datas (they provide a public API). Apparently, these datas currently omit some champions (like Aatrox, for example).

I think there is not much I can do, except wait for the next build generations (every day at 12 AM) until it gets fixed.

Feel free to re-open this issue if you consider that the issue persists for too long :)

Ilshidur commented 6 years ago

Just bumping this post to notify that this bug is fixed.