league-of-legends-devs / LoL-item-sets

[discontinued] A Windows application that downloads and installs the League of Legends item sets from the website 'https://lol-item-sets-generator.org'. Mac version : https://github.com/league-of-legends-devs/LoL-item-sets-Mac
MIT License
32 stars 6 forks source link

It wont launch on startup. #9

Open Vahryx opened 7 years ago

Vahryx commented 7 years ago

I have it ticked in the program. I have the program run as administrator. I have also put a shortcut to the exe in the startup folder. However, it never launches. Any ideas?

Ilshidur commented 7 years ago

Thanks for your report. What is your operating system ?

Vahryx commented 7 years ago

I run Windows 7 Home Premium (64 bit)

Ilshidur commented 7 years ago

Check your registry if the following exists for this application : SOFTWARE\Microsoft\Windows\CurrentVersion\Run.

Sorry, but at the moment I don't have access to a Windows 7 installation to reproduce the bug.

Vahryx commented 7 years ago

Okay, there is no entry for it there. Would I just create a new string value with the value "C:\Users#USER#\Documents\LoL-item-sets-0.3.0\LoL item sets.exe"?

Just to make sure, the name of the value doesn't matter right?

Ilshidur commented 7 years ago

The name of the value must be the full path of the application, so yes, it matters. Make sure to create it for the "current user" (only you).

I tried to fix this problem here and will investigate this.

Vahryx commented 7 years ago

Oops. I was looking for the registry key under local machine, not current user. There IS actually a registry key there for LoL-item-sets-generator with the correct path to the exe.

Sorry about that!

Ilshidur commented 7 years ago

Is the path correct ? Does it begin with a disk letter like C:\ ?

Vahryx commented 7 years ago

Yes. The path is : C:\Users\Vahryx\Documents\LoL-item-sets-0.3.0\ Within this folder is my "Lol item sets.exe"

Could the problem be that the path does not include the exe.

For example should it be : C:\Users\Vahryx\Documents\LoL-item-sets-0.3.0\Lol item sets.exe Rather than : C:\Users\Vahryx\Documents\LoL-item-sets-0.3.0\

Ilshidur commented 7 years ago

O.K. This is what I thought. The key does not contain the .exe file, so the app won't run on Windows startup.

Try to replace the key to the one you suggested. You should be able to see the app running after a restart.

This issue will definitely be fixed in the version 0.3.1.

Vahryx commented 7 years ago

Hmm. It is still not launching on startup.

Here is a screenshot of my regedit window. The path is correct. regedit

And here is a screenshot of my Documents folder just to show I'm not spelling it incorrectly. the exe

Any ideas?

Ilshidur commented 7 years ago

Have you checked the "Run as administrator" checkbox in the app properties ? (right clic > "Properties").

If the registry key HKey_Current_User\Software\Microsoft\Windows\CurrentVersion\Run doesn't work, try with HKLM\Software\Microsoft\Windows\CurrentVersion\Run (local machine). I think this should work.

Vahryx commented 7 years ago

"Run as administrator" is ticked. properties

And I created another registry key in HKEY_LOCAL_MACHINE. regedit2

Still not working. Doesn't make sense to me.

Ilshidur commented 7 years ago

What a wierd behavior.

Maybe try to put quotes (") like "C:\Users\Jack\Documents\LoL-item-sets-0.3.0\LoL item sets.exe" for both keys (local machine and current user).

Vahryx commented 7 years ago

Still not working.

Vahryx commented 7 years ago

I also made sure that they were ticked under "Services" in msconfig.exe

Vahryx commented 7 years ago

Maybe my computer is the problem.

I just created a Scheduled Task for the application and it works fine.

Ilshidur commented 7 years ago

When you added the key in your registry, did your app showed "Launch on Windows start" as checked ?

Or maybe the app itself is the problem. I think you can try to register a key with an other app name (a random .exe file) and see if it runs when you restart.

Vahryx commented 7 years ago

"Launch on Windows start" was checked, yes.

I just tried adding a key in HKEY_CURRENT_USER for another .exe and it did indeed run when I restarted.

Ilshidur commented 7 years ago

This means that the app has successfully read the registry.

Either :

Otherwise, I can't really help you. I'll investigate myself as soon as I get a Windows 7 installation.

Vahryx commented 7 years ago

Thanks for all the help! I really appreciate it.