Clicking buttons too fast causes the player IDs to not be set during the request

leaguevine / leaguevine-ultistats

MIT License

18 stars 4 forks source link

Clicking buttons too fast causes the player IDs to not be set during the request #38

Closed mliu7 closed 12 years ago

mliu7 commented 12 years ago

When using the app, the player IDs seem to be set appropriately for the most part, but when I clicking buttons very quickly these IDs occasionally do not get set. By "setting the player IDs" I mean adding the appropriate Player ID to the JSON that gets sent to the server on the request.

Using Chrome on my fast desktop, the rate at which this begins to happen is at approximately 3 taps/second. I have not tried to reproduce this on a mobile phone yet.

mliu7 commented 12 years ago

I've found the bug and will fix it now. It had nothing to do with how fast I was tapping it, but with where on the button I was tapping. The fix is super easy and I just had to modify the selector we use.