Player button ordering on substitution screen

[mliu7]

The players on the substitution screen are displayed in a random order, making it difficult to find the players we are looking for.

I think we should sort using the following attributes in this order:

• number
• last name
• first name

[cboulay]

If we sort by number the other attributes shouldn't matter because number should be unique. In fact we already are sorting by number. The problem is that we don't seem to know the number, at least not right away. This is obvious when we start entering stats the player buttons don't have numbers below them, but later they do.

So why don't we have the numbers right away?

Anyway, since the roster list and the player buttons in the action screen SHOULD be from the same Collection, they SHOULD be sorted the same way. Thus we need to decide on a sorting that fits both. Maybe last name + first name is the best way.

[cboulay]

I have fixed this on my copy but I'm now encountering error 503 from the API. I'll wait until that's resolved to test/push.

[mliu7]

Cool, thanks for the fix. Looks good to me.

[mstac]

Just to chime in here, speaking as someone who was going to attempt to take stats for an AUDL game specifically, i'm greatly in favor of at least allowing the user to pick the players by number. In the AUDL, there's very little time between points and its simply much quicker for a spotter to rattle off 7 numbers than find a number on a list and translate to a name which is then selected. More conventional ultimate games don't have this time constraint and also dont have the benefit of players always having a number.

[mliu7]

Josh Fortney, chimed in on this as well, saying it'd be nice to order by either number or last name. I agree that it would be really nice to be able to choose. I'm going to re-open this issue now.

To close this out, I propose we do the following:

• Have a button on the settings page, that allows a user to choose whether to order by number or by last name
• Have these changes reflected both in the ordering of the buttons on the substitution page, and on the player buttons on the main game tracking screen.

[cboulay]

That's fine but can we wait a bit on this? I want to do the Settings screen right instead of hacking together things as feature requests come up.

On 5/7/2012 11:40 AM, Mark Liu wrote:

Josh Fortney, chimed in on this as well, saying it'd be nice to order by either number or last name. I agree that it would be really nice to be able to choose. I'm going to re-open this issue now.

To close this out, I propose we do the following:

• Have a button on the settings page, that allows a user to choose whether to order by number or by last name
• Have these changes reflected both in the ordering of the buttons on the substitution page, and on the player buttons on the main game tracking screen.

---

Reply to this email directly or view it on GitHub: https://github.com/leaguevine/leaguevine-ultistats/issues/48#issuecomment-5543047

[mliu7]

Sounds good to me. I'd be happy if you set up the initial settings page once you're done with the WebSQL and undo button stuff, since you're the most familiar with how to structure things in backbone.

[cboulay]

I don't know if I'm the most familiar anymore... but I wanted to have a discussion about this first.

How should we store settings? localStorage seems like the best way. Do we use individual entries or do we have an list/array/struct/dict called "settings"?

I would like there to be a "settings" variable with keys for the setting name and value for the value. This would also require another variable called "settings_type" which uses the same keys as "settings" but here the values are what type of UI element we should use. Then when the settings page is loaded we can iterate over the "settings" items to display the appropriate UI elements set to the value. Any change should automatically be stored in localStorage without the user having to press "save" or something like that.

[mliu7]

All of this sounds good to me. I agree with you on your plan for the settings variable, along with the settings_type variable. Thanks for thinking through this.

[cboulay]

Fixed in chadapache. Closing this issue for now.