search

leaguevine / leaguevine-ultistats

MIT License
18 stars 4 forks source link

End of period should change the game tracking state to pulling #57

Closed mliu7 closed 12 years ago

mliu7 commented 12 years ago

After a user clicks the "End of Period" button, when the user returns to the main game tracking screen, they should be prompted with "Who pulled?".

This issue arises when people are taking stats for the AUDL where the end of a period doesn't necessarily correspond to a completed pass for a score. Right now, clicking the "End of period" button correctly sends an end of period event type to the server but the game state is not changed so there is no way to specify who pulled to start the next period.

cboulay commented 12 years ago

I guess when I set that up I didn't realize that a period could end without a score. In USAU a "point" is always whole, and a game can always be divided up into an integer number of points. That is no longer true in AUDL, and thus "point" is no longer a good way to encapsulate a set of events. I hope my preconceptions about how to segment games aren't coded into the app in too many places.

On 4/23/2012 12:06 PM, Mark Liu wrote:

After a user clicks the "End of Period" button, when the user returns to the main game tracking screen, they should be prompted with "Who pulled?".

This issue arises when people are taking stats for the AUDL where the end of a period doesn't necessarily correspond to a completed pass for a score. Right now, clicking the "End of period" button correctly sends an end of period event type to the server but the game state is not changed so there is no way to specify who pulled to start the next period.

Reply to this email directly or view it on GitHub: https://github.com/leaguevine/leaguevine-ultistats/issues/57

rrw4 commented 12 years ago

At least from what I've observed, the description is slightly inaccurate - the app always specifies who pulled to start the next period after an "End of Period", but the "End of Period" can only be selected after a score, from the substitution page (otherwise does nothing).

So, it seems like this issue should represent being able to select "End of Period" even after a non-score event, and change the state to pulling after that. Is this correct?

mliu7 commented 12 years ago

@rrw4 yes, your clarification is correct.

cboulay commented 12 years ago

Before I understood the AUDL rules I deleted the "End of Period" button from the action screen. It needs to be replaced. If possible, try to place it in the exact same screen coordinates on both the game action screen and the substitution screen.

cboulay commented 12 years ago

Actually that's not the right way to approach it. I think we should use the same button and it should always be visible independent of whether the game action screen is visible or the sub screens are visible.

mliu7 commented 12 years ago

Hmm, if the button is persistent across both those screens, where would it be located? I can't think of any logical place to put it.

Somewhat related to this, will there be an "Undo" button on the substitution screen? If not, the cost of clicking the "End of Period" button at the wrong time would be very high because it messed up the state of the game. If we plan on having an "Undo" button on the substitution screen, then this is a non-issue.

Another thing to consider - I think that having the button only on the substitution screen isn't that terrible for the AUDL. The stat takers already know to substitute people in and out at the half and seem to consistently navigate to the substitution page ok when needed.

cboulay commented 12 years ago

That makes sense.

Maybe at some point in the future we can get rid of the "Next" "Done" and "Substitution" buttons and instead replace them with a single button (with a clever image) that rotates through the 3 screens.

mliu7 commented 12 years ago

Interesting idea with the single button at the bottom. I could see that being very easy to use if we implement it well. Can't believe I never thought of that.

Could you address the question I had about the "Undo" button on the substitution screen?

cboulay commented 12 years ago

Being able to quickly rotate through the screens will also help with indoor ultimate and hockey with subs on the fly.

If we can rotate through the screens quickly without that rotation having any implication for the game state, then the Undo button can stay where it is.

We might even consider not automatically switching to the substitution screen after a score and forcing the user to press it. It'll help them think of the 3 screens as always active and always available, not as modal screens that are only available under certain conditions.

mliu7 commented 12 years ago

Yeah, I agree. One downside I see, though, is that unless we use a slide animation for this transition, it might not be totally intuitive. I guess we'd have to implement it to really see how intuitive it would be.

cboulay commented 12 years ago

I've implemented this in the undo branch but the button is ugly. It needs its html template cleaned up and the css fixed. Can someone that has been handling the CSS do that?