search

leaguevine / leaguevine-ultistats

MIT License
18 stars 4 forks source link

Users often navigate to /settings or /teams #70

Closed mliu7 closed 12 years ago

mliu7 commented 12 years ago

For some reason, users have been navigating to the urls /teams, /tournaments, /games, and /settings

I have been receiving errors in my inbox whenever people navigate here because these are invalid Ultistats URLs.

Chad - Do you have any idea how a user could manage to navigate to these URLs instead of /#settings or /#teams?

cboulay commented 12 years ago

It has to do with pushState. You can try to fix it now by editing main.js and changing Backbone.history.start({ pushState: false }); to Backbone.history.start({ pushState: true });

I couldn't get this to work for me at home because either I couldn't get the app served in the web server's root (if I was using apache) or I couldn't get pushState to work for me when using node.js You can try to get this to work on your setup. It's something that I meant to try when I got the app served locally at the web root when using apache. There are some links on how to do this in one of the e-mails I sent you in the past couple days.

On 6/7/2012 11:26 AM, Mark Liu wrote:

For some reason, users have been navigating to the urls /teams, /tournaments, /games, and /settings

I have been receiving errors in my inbox whenever people navigate here because these are invalid Ultistats URLs.

Chad - Do you have any idea how a user could manage to navigate to these URLs instead of /#settings or /#teams?

Reply to this email directly or view it on GitHub: https://github.com/leaguevine/leaguevine-ultistats/issues/70

mliu7 commented 12 years ago

Hmm, It's currently at pushState: false and uses the URLs /#teams and /#settings correctly for the most part (except for one or two errors I get per day). When I changed it to pushState: true backbone redirected any urls starting with /#teams to /teams. So I think pushState: false is the way to go.

Still not sure why a few users are visiting the urls that don't start with hashes.

cboulay commented 12 years ago

I meant that if you set pushState: true then the app will use /teams instead of /#teams... and the router should recognize /teams. If /teams becomes the default for everyone, then users that type in the address bar directly won't have any trouble.

On 6/7/2012 11:58 AM, Mark Liu wrote:

Hmm, It's currently at pushState: false and uses the URLs /#teams and /#settings correctly for the most part (except for one or two errors I get per day). When I changed it to pushState: true backbone redirected any urls starting with /#teams to /teams. So I think pushState: false is the way to go.

Still not sure why a few users are visiting the urls that don't start with hashes.

Reply to this email directly or view it on GitHub: https://github.com/leaguevine/leaguevine-ultistats/issues/70#issuecomment-6167861

mliu7 commented 12 years ago

Ah gotcha.

I wonder if people are accessing that because they are on a really old version of Ultistats before we implemented the appcache. Anyone on the newer versions will be prompted to reset their cache and fully upgrade to the newer version so hopefully the people using those old versions just happen to clear their caches and refresh to the new version of the site on their own... I'm having this same problem on Leaguevine Mobile right now because I never implemented a mechanism for detecting when a user is using an old version.

If you agree and think that it's just because a few users are using a really old version of Ultistats, then we can just mark this issue as closed.

cboulay commented 12 years ago

Closing this issue too because it's working in chadapache branch.

mliu7 commented 12 years ago

Excellent. My inbox thanks you :)

On Wed, Jun 20, 2012 at 12:21 PM, Chadwick Boulay < reply@reply.github.com

wrote:

Closing this issue too because it's working in chadapache branch.

Reply to this email directly or view it on GitHub:

https://github.com/leaguevine/leaguevine-ultistats/issues/70#issuecomment-6459472