search

leaguevine / leaguevine-ultistats

MIT License
18 stars 4 forks source link

Login redirects don't work on ios #88

Closed mliu7 closed 12 years ago

mliu7 commented 12 years ago

I merged the new faster roster branch into master and everything is working beautifully on chrome. However, in the ios simulator and in safari, after logging in, the user is redirected back to the base teams list page instead of the track game screen. Subsequent clicks on the "Take stats" button take the user back to the teams list page as well.

I'm really not sure what's going on. I hope it wasn't something to do with my merge, but I'm just opening this issue for reference.

cboulay commented 12 years ago

I modified assets/js/plugins/localSettings.js, and this modified version, including a new token AND the redirect_uri: "http://ultistats.localhost", probably got built in to release.js I think to get around this problem you'll have to modify localSettings.js and rebuild.

Maybe we should .gitignore localSettings?

Also, I changed the login redirects for development purposes. I stopped using app.API.is_logged_in, because it would return false even if the token was specified in localSettings. I'm working on a compromise now.

cboulay commented 12 years ago

Safari is still broken. I have to go to work.

cboulay commented 12 years ago

Here was the problem. http://stackoverflow.com/questions/4310953/invalid-date-in-safari Safari doesn't support the standard.

I fixed it. Found another problem. Fixed it. I'll be sure to work Safari into my debugging before suggesting we merge a branch.

mliu7 commented 12 years ago

Dang, good find. Thanks for fixing that so quickly!