The app sometimes won't show the action screen

[mliu7]

Mike Nash has been taking stats for his own games and reported this bug to me last night while taking stats for the NexGen game. 75% of the way into the game, he ran into a situation where he was only able to switch between the substitution screens and never get back to the action screen. This is the game where the problem occurred:

https://www.leaguevine.com/games/78814/

I have not been able to reproduce this issue yet, but still wanted to open this issue so we can start some discussion and find a way to reproduce it.

[cboulay]

Can you find out if the action screen was simply skipped (rotating between rosters only), or if it was blank (except for the scoreboard)? If it was blank, then that probably means that there was some bad data causing the page to throw an error before it rendered.

Right now, each of the views (roster1, roster2, action) are completely replaced whenever the user rotates through the screens. This means that everything is re-rendered. I suppose I don't need to do that, I can simply toggle the visibility when that button is pressed. If I did this then SOMETHING would show up, even if there were bad data. This is also faster. However, I have to be more careful about bindings otherwise I may end up re-rendering the player buttons on all 3 screens every time a single player is subbed.

I was thinking of doing this anyway, so I'll implement it soon, but it will merely allow for a more detailed description of the symptoms, it won't cure the original disease.

[RobertStats]

It wasn't a matter of the action screen being blank. Roster 1 screen showed properly, Roster 2 screen showed properly, the Action button was at the top right of the screen. When I hit it, it seemed sluggish and eventually it skipped back to Roster 1. I did this several times being very careful about how I hit the buttons. Similar functionality.

It may be related to another bug we experienced later - we did a lot of undo-ing. One bug that is repeatable (haven't checked to see if it is already posted) is to tap the D'd button, the app then asks who defended it. Before you select a person, if you hit undo, it goes back to the play before, however, it also leaves the lineup for the defending team on the screen (which is the wrong lineup). To get realigned to the proper line up on the screen - I repeated the process. D'd, undo. I imagine drops, stalls - all 2 part events have the issue, but I do not know.

We undid a lot of roster adds and removes as well - an artifact of how we had to figure out the lineup. I don't know if this contributed to the problem.

[cboulay]

I doubt the problems are related. Your method for undoing the turnover should be innocuous.

I can't begin to guess what caused the first problem. I made some significant changes that should either fix the problem or make it so more details are available when the problem occurs.

Undoing roster additions shouldn't cause any problems either. Actually, the way Leaguevine is setup, you shouldn't have to undo roster additions, but you can go back to the roster page and change their status there. These do register extra events (e.g., X stepped on the field), but I think Leaguevine knows to ignore substitutions except those that result in the final 7 on the line at the time of the pull. Mark or Roger, is that accurate?

I will create a new issue for undoing a D. I hope you can comment on it there.

[cboulay]

Refs #91.