search

leaguevine / leaguevine-ultistats

MIT License
18 stars 4 forks source link

Default ordering on the lineup page should be by number #99

Closed mliu7 closed 11 years ago

mliu7 commented 11 years ago

So far just about all the users I know who are using the system have the ordering by number. The few who aren't simply didn't know about the functionality. Zack Purdy had a good comment about this as well, noting that if the stat keeper knows the player well enough to know their last name they probably know what their number is as well.

I attempted to change the default ordering myself, and it shows up correctly as jersey under the settings tab. However, it isn't ordered by jersey until I go to the settings tab, change the ordering to something else, and then change it back to jersey.

mliu7 commented 11 years ago

Holy cow that was fast. I just deployed the latest version with this change.

cboulay commented 11 years ago

It was a simple fix. I noticed that when some jersey values are present but not all, it seems to put those without a jersey number first and I'm not sure what the secondary sorting criterion is. Also, number 0 seems to come before number null but number 1 is after number null. I didn't notice that until after I pushed the changes. I don't think it's a big deal. Maybe users will be encouraged to add jersey numbers to missing players.

mliu7 commented 11 years ago

Sounds good. Thanks for the info!