search

leahneukirchen / dosfetch

NeoFetch clone for DOS
145 stars 7 forks source link

Machine Type wrongly detected. An XT machine is displayed as being AT type. #9

Open igully opened 1 year ago

igully commented 1 year ago

Found a bug in the machine detection code. To reproduce it:

Windows 10 PRO emulating an old PC XT using 86Box 3.11 (https://86box.net/) In Settings I chose:

Machine type: 80286 Machine: [ISA] IBM XT Model 286 Display: [ISA] VGA

I booted MS-DOS 6.22 from a floppy disk image. DOSFETCH reported an AT machine, when it should have been XT. Even old and rusty MSD.EXE recognized an XT BIOS when run. So I assume it must be something not entirely reliable in the machine detection routine.

BTW, thank you for your work.

leahneukirchen commented 1 year ago

is this related to #8?

igully commented 1 year ago

is this related to #8?

It may certainly be the case.

doekman commented 1 year ago

Since pull request #8 is not (yet) accepted, I'll take the discussion to the pull request.