search

leahneukirchen / mblaze

Unix utilities to deal with Maildir
Other
445 stars 48 forks source link

Support pledge() on OpenBSD #79

Closed holsta closed 3 years ago

holsta commented 6 years ago

I should like some input and testing on non-OpenBSD platforms on these changes.

Also, anyone on OpenBSD who can verify the pledges does not break functionality are invited to try out this work.

snimmagadda commented 6 years ago

Few observations...

  1. mexport.c mflag.c mgenmid.c require #include .
  2. mime.c msed.c mseq.c mshow.c msort.c missing ifdef OpenBSD guard around pledge.
  3. It would be nice and also easy to read diff if you can separate whitespace changes from the pr.

Will start testing with this diff and report any pledge violations.

holsta commented 6 years ago

Thanks for the input, @snimmagadda.

In the mean time, chneukirchen clairfied to me that they prefer to avoid the ifdefs and instead wrap the pledge call in xpledge(). Should we just keep local patches in the port, do you think?

timkuijsten commented 4 years ago

Hi all,

I'm interested in this work. As a first step I have rebased the patches from Alex on master (can't find the original repository from Alex anymore so I grepped 0300a112 from this PR and created a new commit myself which credits Alex).

@leahneukirchen where would you like to have xpledge defined? I don't see a generic include used by all progams.

(for those interested I'm working in https://github.com/timkuijsten/mblaze/tree/renewpledge)

leahneukirchen commented 4 years ago

I think blaze822.h is used by most code. Put xpledge into a separate file.