What technical change you'd like to see implemented in our project?
The build-and-publish.yml GitHub action has the following problems, which need to be addressed in order to get the deployments being executed successfully:
The values from secrets.STAGING_INFRA|PROD_INFRA cannot be used to hold strings to check their values, so the following conditions on STAGING_INFRA|PROD_INFRA will always fail
The conditions startsWith(github.ref, '/develop') and startsWith(github.ref, '/main') will always evaluate to false, so they must be removed
Regarding the first bullet point a better approach to endsWith(env.PROD_INFRA, 'up') would be have a check based on the latest commit message, i.e.: !endsWith(github.event.head_commit.message, 'no-deploy')
Code of Conduct
[X] I agree to follow this project's Code of Conduct
Contact Details
No response
What technical change you'd like to see implemented in our project?
The
build-and-publish.ymlGitHub action has the following problems, which need to be addressed in order to get the deployments being executed successfully:secrets.STAGING_INFRA|PROD_INFRAcannot be used to hold strings to check their values, so the following conditions onSTAGING_INFRA|PROD_INFRAwill always failhttps://github.com/lealceldeiro/org.wcdevs.blog.front/blob/ba15c2388a66c8aaa9810870dc20e7b09380c28b/.github/workflows/build-and-publish.yml#L35
startsWith(github.ref, '/develop')andstartsWith(github.ref, '/main')will always evaluate tofalse, so they must be removedendsWith(env.PROD_INFRA, 'up')would be have a check based on the latest commit message, i.e.:!endsWith(github.event.head_commit.message, 'no-deploy')Code of Conduct