search

leamas / ddupdate

Update DNS Data for Dynamic IP Addresses
MIT License
40 stars 28 forks source link

Add option to log IP changes #31

Closed aerusso closed 5 years ago

aerusso commented 5 years ago

It may be useful to have an option to always track changes to the updated IP address. This introduces such a configuration file and command line option, log-ip and --log-ip, independent of the current logging framework.

leamas commented 5 years ago

hm... I sort of hesitate to add a random printout for a random need. We need a better motivation than it might be useful, for sure.

Could we possibly just add a LOG_INFO instead, which is visible in the default setup?

aerusso commented 5 years ago

So, I added this because I specifically like having a log of the IPs that are assigned to me, and when they change. In particular, you can be confident of how frequently your address is changing, and if you might need to increase your timer frequency.

I don't want to clutter my logs with more stuff (esp. at INFO verbosity). I originally implemented this with just a WARN level verbosity, but it's not "really" a warning, but thought the community might appreciate a flag.

leamas commented 5 years ago

There is a complexity price on a adding an option for both users and maintainers. Frankly, the benefits of this "irregular" printout does not justify the costs in this case.

Thanks for the PR. Might add an a info log statement later