Closed LoganK closed 5 years ago
leamas
commented
5 years ago hmm.. Thanks for taking care of this, most welcome!
While we are on it: Could you please add some error checking? Basically, take the return value from get_response()and log an error if it's not OK. There are plenty of examples in other plugins.
LoganK
commented
5 years ago Absolutely. Update soon.
LoganK
commented
5 years ago I split it into two different pull requests so there could be consistent logging and error checking across similar plugins. Please take a look at #33 first.
leamas
commented
5 years ago hm... actually, I'm not really fond of this. Adding server-specific code to ddplugin should not be done lightly, and here I cannot see that the advantages (less duplication) justifies expanding ddplugin.
In short: Could you update the requests by simply duplicating this code in the two service plugins without touching ddplugin I would happily merge them both.
LoganK
commented
5 years ago Code duplicated across plugins.
leamas
commented
5 years ago hm... is it? Have you forgot to push something? Or do I miss something else? I see just the old code callingcheck_dyndns_response()?!
LoganK
commented
5 years ago Blergh, sorry about that. The changes got stuck in the index.
leamas
commented
5 years ago No problem ;)
All looks fine. I have merged this into the devel branch. This is the new default branch, master is from now on basically just the released stuff.
Again: many thanks for taking care of this. Closing
Closes #15