search

leamas / ddupdate

Update DNS Data for Dynamic IP Addresses
MIT License
40 stars 28 forks source link

Installation fails with: SyntaxWarning: "is not" with a literal. #40

Closed ruedigerkupper closed 4 years ago

ruedigerkupper commented 4 years ago

Trying to install the ddupdate package from Ubuntu focal repo fails with:

/usr/lib/python3/dist-packages/ddupdate/ddplugin.py:178: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  words = [ word for word in line.split(' ') if word is not '' ]

and service ist not istalled:

systemctl status ddupdate.timer 
Unit ddupdate.timer could not be found.
ruedigerkupper commented 4 years ago

ddupdate-config fails with

Starting service and displaying logs
Failed to start ddupdate.service: Unit ddupdate.service has a bad unit file setting.
See user logs and 'systemctl --user status ddupdate.service' for details.
No journal files were found.
-- No entries --
Use "journalctl --user -u ddupdate.service" to display logs.
Shall I run service regularly (Yes/No) [No]: Yes

Starting and enabling ddupdate.timer
Job failed. See "journalctl -xe" for details.
leamas commented 4 years ago

Ack, needs a fix. It's new behaviour in recent python. Will look into it, time permitting.

leamas commented 4 years ago

The root cause here seems to be a misconfigured /usr/lib/python3/dist-packages/ddupdate/install.conf which reads (excerpt)

root = debian/tmp
install_purelib = debian/tmp/usr/lib/python3/dist-packages
install_platlib = debian/tmp/usr/lib/python3/dist-packages
install_lib = debian/tmp/usr/lib/python3/dist-packages/
install_headers = debian/tmp/usr/include/python3.7/ddupdate
install_scripts = debian/tmp/usr/bin
install_data = debian/tmp/usr

You should be able to walk around the problem by fixing this file. Note that the syntax warning needs to be fixd as well, but it should actually not be a blocking error.

ruedigerkupper commented 4 years ago

Thank you, I already wondered, as it is a warning only and should not actually break execution. Any idea what is misconfigured in install.conf?

leamas commented 4 years ago

This is a debian packaging; it will take some time before I can submit a new build. Leaving bug open.

ruedigerkupper commented 4 years ago

Separated the two issues.

ruedigerkupper commented 4 years ago

Oops, you were faster ;-).

leamas commented 4 years ago

The warning is already fixed in master: 7b7f86db75

ruedigerkupper commented 4 years ago

So it actually was so easy, thanks! I leave it to you which of #40 and #41 to keep and which to close, sorry for the mess :-).

leamas commented 4 years ago

I'm closing this as fixed in 7b7f86d.

Thanks for reporting!