leamas / ddupdate

Update DNS Data for Dynamic IP Addresses
MIT License
40 stars 28 forks source link

Add `requests` dependency #48

Closed im-0 closed 2 years ago

im-0 commented 3 years ago

requests is required for Cloudflare plugin.

leamas commented 2 years ago

hm... I have tried to keep the dependencies as few as possible. And in principle, we should probably not add a dependency to the overall project just because a plugin needs it but rather make runtime checks in the plugin. I will look into this.

Seen this way this is a good bug report, thanks for that!

EDIT: Leaving the PR open as a reminder until fixed.

leamas commented 2 years ago

I have

These steps should handle missing a python3-requests without bogging down the package with more absolute dependencies. In a better world the cloudflare plugin should be packaged in a separate package with it's own dependencies. However, the world is yet not perfect.

Thanks for your heads-up on this issue!

Closing