leamas / lpf

lpf - Local Package Factory
MIT License
61 stars 6 forks source link

Readme is missing dependencies #22

Closed rgeary1 closed 10 years ago

rgeary1 commented 10 years ago

The lpf build requires appdata-tools and inotify-tools

leamas commented 10 years ago

This is using 0.10 (from updates-testing), right?

EDIT: I presume that when you say that 'lpf build requires' you refer to the lpf build command, not building the lpf package?!

EDIT (again): Looking at 0.10, I get the impression that appdata-tools is required to build the lpf package, but not to run 'lpf build'. And the package has a BuildRequires: appdata-tools.

Also, inotify-tools are certainly required for the lpf package to work, but not to build it. SInce it builds in mock and koji I think it''s safe to say that the BuildRequires are OK. And it has a Requires: inotify-tools.

So: what am I missing?

rgeary1 commented 10 years ago

Sorry for the lack of detail in the OP - I checked out the lpf git repository, read the readme and ran the tools/make_rpm script & the rpm -U command. I was missing both these packages, I assumed they should be mentioned as prerequisites in the README.

Thanks!

leamas commented 10 years ago

Oops, I missed the header, it seems ;). I didn't explicitly list the dependencies (maintenance problems), but rather added a note about looking into the spec file. Thanks for reporting!