search

lean-delivery / ansible-role-oracle-db

Apache License 2.0
20 stars 13 forks source link

Comparison to literal Bool should be fixed #5

Closed kharkevich closed 5 years ago

kharkevich commented 5 years ago
SUMMARY

Broken E601 from Ansible Galaxy (https://github.com/ansible/galaxy-lint-rules/blob/master/rules/ComparisonToLiteralBoolRule.py)

ISSUE TYPE
COMPONENT NAME
STEPS TO REPRODUCE

Broken files tasks/oraInst/checkOraInst.yml tasks/main.yml tasks/system/swap.yml

    - name: "Create swapfile"
      command: "dd if=/dev/zero of={{ oracledb.swapfile_path }} \
        bs={{ oracledb.swapfile_bs_size_mb }}M \
        count={{ oracledb.swapfile_count }}"
      when: swapfile.stat.exists == False
EXPECTED RESULTS
    - name: "Create swapfile"
      command: "dd if=/dev/zero of={{ oracledb.swapfile_path }} \
        bs={{ oracledb.swapfile_bs_size_mb }}M \
        count={{ oracledb.swapfile_count }}"
      when: not swapfile.stat.exists
AlekseiSidorenko commented 5 years ago

The following task was created: https://jira.epam.com/jira/browse/EPMLDI-1441

AlekseiSidorenko commented 5 years ago

done