leancloud / php-sdk

LeanCloud PHP SDK
Apache License 2.0
53 stars 23 forks source link

🎉 Support PHP 7.2 (Rename Object -> LeanObject) #175

Closed jysperm closed 6 years ago

jysperm commented 6 years ago

https://github.com/leancloud/php-sdk/issues/174

为了支持 PHP 7.2,将 Object 更名 LeanObject,同时在 7.2 以下继续对 Object 提供兼容:

对测试和文档的改动:

建议 review 时下载到本地搜索 ObjectLeanObject 来逐处检查,尤其是字符串(错误提示)和注释中。

这些修改应该会被发布成 0.8,发布后的一些工作:

codecov-io commented 6 years ago

Codecov Report

Merging #175 into master will decrease coverage by 0.22%. The diff coverage is 86.56%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #175      +/-   ##
============================================
- Coverage     67.46%   67.24%   -0.23%     
- Complexity        0      793     +793     
============================================
  Files            35       36       +1     
  Lines          2241     2250       +9     
============================================
+ Hits           1512     1513       +1     
- Misses          729      737       +8
Impacted Files Coverage Δ Complexity Δ
src/LeanCloud/User.php 79.62% <ø> (ø) 52 <0> (+52) :arrow_up:
src/LeanCloud/Bytes.php 100% <ø> (ø) 7 <0> (+7) :arrow_up:
src/LeanCloud/SaveOption.php 90.9% <ø> (ø) 5 <0> (+5) :arrow_up:
src/LeanCloud/File.php 82.99% <ø> (ø) 56 <0> (+56) :arrow_up:
src/LeanCloud/Role.php 100% <ø> (ø) 4 <0> (+4) :arrow_up:
src/LeanCloud/Engine/Cloud.php 88.52% <ø> (ø) 24 <0> (+24) :arrow_up:
src/LeanCloud/Relation.php 70% <0%> (ø) 17 <1> (+17) :arrow_up:
src/LeanCloud/BatchRequestError.php 65% <0%> (ø) 10 <0> (+10) :arrow_up:
src/LeanCloud/Object.php 0% <0%> (-89.67%) 0 <0> (ø)
src/LeanCloud/Operation/ArrayOperation.php 89.87% <100%> (ø) 35 <0> (+35) :arrow_up:
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a07b2a0...14880aa. Read the comment docs.