search

leancloud / php-sdk

LeanCloud PHP SDK
Apache License 2.0
53 stars 23 forks source link

:sparkles: loginWithEmail #185

Closed weakish closed 5 years ago

weakish commented 5 years ago

没跑测试（ API 后端没上线）

weakish commented 5 years ago

不知道是不是因为这个 pr 最初是 draft pr 的关系，Travis CI 一直没有跑，改了一个注释的大小写 push -f 一下触发了 CI。

loginWithEmail 的测试过了。有一个和路由相关的测试没过，改动并不涉及路由，不太清楚是不是因为后端 API route 的变动导致的， @juvenn 来看下。

codecov-io commented 5 years ago

Codecov Report

Merging #185 into master will increase coverage by 0.16%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #185      +/-   ##
============================================
+ Coverage     67.18%   67.34%   +0.16%     
- Complexity      793      795       +2     
============================================
  Files            36       36              
  Lines          2249     2257       +8     
============================================
+ Hits           1511     1520       +9     
+ Misses          738      737       -1
Impacted Files Coverage Δ Complexity Δ
src/LeanCloud/User.php 80.47% <100%> (+0.84%) 54 <2> (+2) :arrow_up:
src/LeanCloud/Client.php 84.45% <0%> (+0.06%) 95% <0%> (ø) :arrow_down:
src/LeanCloud/AppRouter.php 70.52% <0%> (+1.05%) 35% <0%> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 90afdc2...19949d0. Read the comment docs.

weakish commented 5 years ago

看起来默认路由部分的代码需要更新，暂时先小幅改动了测试，避免测试不过阻塞 merge