search

leanderloew / Semi-Supervised-Segmentation-Pytorch

A repository for semi supervised image segmentation using Mean Teacher
Apache License 2.0
30 stars 5 forks source link

About the EMA #1

Open YilinLiu97 opened 5 years ago

YilinLiu97 commented 5 years ago

Hi @lysecret2 , thanks for your implementation. Have you tested your code and may I ask about the results? As I found that the original implementation for the EMA updating rule may be wrong and am wondering about the results that you got.

I think that this line ema_param.data.mul_(alpha).add_(1 - alpha, param.data) should be 'emaparam.data.mul(alpha).add_((1 - alpha)*param.data)'

It would be greatly appreciated if you could let me know about the results that you got!

leanderloew commented 5 years ago

Hey! Thanks for the hint. I will look into it.

leanderloew commented 5 years ago

Hi @lysecret2 , thanks for your implementation. Have you tested your code and may I ask about the results? As I found that the original implementation for the EMA updating rule may be wrong and am wondering about the results that you got.

I think that this line ema_param.data.mul_(alpha).add_(1 - alpha, param.data) should be 'emaparam.data.mul(alpha).add_((1 - alpha)*param.data)'

It would be greatly appreciated if you could let me know about the results that you got!

So I took the code from here: https://github.com/CuriousAI/mean-teacher/blob/master/pytorch/main.py