Suggestion: Use Androidx Lifecycle to Internalize Disposal of Retained Memory

leandroBorgesFerreira / LoadingButtonAndroid

A button to substitute the ProgressDialog

MIT License

1.94k stars 214 forks source link

Suggestion: Use Androidx Lifecycle to Internalize Disposal of Retained Memory #102

Closed wokkaflokka closed 5 years ago

wokkaflokka commented 5 years ago

README currently mentions the requirement of calling dispose in onDestroy to avoid leaking memory. This library might be able to make use of the androidx lifecycle components in a way where memory management can be internalized by the library, rather than pushed to consumers.

leandroBorgesFerreira commented 5 years ago

@wokkaflokka I don't have much experience with the new Androidx Lifecycle. Could you open a PR showing how this could be done or give further explanations?

wokkaflokka commented 5 years ago

👍 will do.